[crypto] Add OAEP padding for RSA. #20713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
approved these changes
Dec 21, 2023
moidx
approved these changes
Dec 22, 2023
| * | ||
| * This is convenient to have available for some implementations. | ||
| */ | ||
| static const entropy_seed_material_t kEntropyEmptySeed = { |
There was a problem hiding this comment.
You probably need to move this to entropy.c and declare it here as an extern so that it is more stylistic.
This padding mode is used for RSA encryption and is defined in IETF RFC 8017. Signed-off-by: Jade Philipoom <[email protected]>
jadephilipoom
force-pushed
the
rsa-oaep
branch
from
711a043 to
4ddc85b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This padding mode is used for RSA encryption and is defined in IETF RFC 8017.
I couldn't find any tests for OAEP specifically, but I implemented RSA encryption on top of this and got it passing tests. The encryption code and tests will be in a follow-up PR or two for size reasons.